-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat(invitation): add #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new table `invitation`and a new enumeration type `invitation_action`have been added.
129be8d to
18bf117
Compare
dargmuesli
reviewed
Feb 3, 2025
dargmuesli
reviewed
Feb 4, 2025
Member
dargmuesli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the meeting yesterday, let's transform this into a sub-table of the notification table.
Table `invitation` now inherits from table `notification`which was moved from schema `maevsi_private` to schema `maevsi`. In orrder to make functions originally created in `test_account_blocking.sql` generally available for all tests (including tests for invitations), these functions were moved to `function_test_utilities.sql`.
All occurrences of "maevsi" have been replaced by "vibetype".
e4ef660 to
4cd6745
Compare
New scripts files for invitation are added at the end of `sqitch.plan`.
Member
|
@sthelemann if #176 is the successor of this PR, you can close this one. |
Contributor
Author
|
#176 is the successor of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new table
invitationand a new enumeration typeinvitation_actionhave been added.