Update f90/CMakeLists.txt only use Fortran Flags for Fortran files#39
Merged
MiCurry merged 1 commit intomagnetotellurics:mainfrom Mar 5, 2026
Merged
Conversation
MiCurry
force-pushed
the
cmake_c_compiler_option_protection
branch
from
0b5fa23 to
74a5c62
Compare
Before, several flags were being specified for the ModEM target that were not properly being wrapped in a CMake generator expression. Currently this is not a problem at all, but it would prevent any C files to be included, as CMake will try to use these flags when compiling a C file. This will prevent that issue occurring if a C file is added in the future.
MiCurry
force-pushed
the
cmake_c_compiler_option_protection
branch
from
74a5c62 to
6e36621
Compare
MiCurry
added a commit
to MiCurry/ModEM
that referenced
this pull request
Mar 16, 2026
…magnetotellurics#39) Before, several flags were being specified for the ModEM target that were not properly being wrapped in a CMake generator expression. Currently this is not a problem at all, but it would prevent any C files to be included, as CMake will try to use these flags when compiling a C file. This will prevent that issue occurring if a C file is added in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, several flags were being specified for the ModEM target that were not properly being wrapped in a CMake generator expression. Currently this is not a problem at all, but it would prevent any C files to be included, as CMake will try to use these flags when compiling a C file.
This will prevent that issue occurring if a C file is added in the future.