Skip to content

Conversation

SameeraPriyathamTadikonda
Copy link
Contributor

@SameeraPriyathamTadikonda SameeraPriyathamTadikonda commented Sep 2, 2025

Description

Checklist:

  • Owner:
  • JIRA_ID as part of branch/PR name

  • Rebase the branch with upstream

  • Squashed all commits into a single commit

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds copyright header validation to the GitHub Actions workflow, implementing an automated check to ensure all files contain proper copyright headers.

Key changes:

  • Integrates a reusable copyright validation workflow into the existing PR workflow
  • Configures copyright validation with a start year of 2018 and specific file exclusions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/pr-workflow.yaml Adds copyright validation job with appropriate permissions
.copyrightconfig Defines copyright validation configuration with start year and file exclusions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +17 to +19
copyright-validation:
name: © Validate Copyright Headers
uses: marklogic/pr-workflows/.github/workflows/copyright-check.yml@main
Copy link
Preview

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using @main as the workflow reference creates a security risk as it always pulls the latest version without verification. Consider pinning to a specific commit SHA or tagged version for better security and reproducibility.

Copilot uses AI. Check for mistakes.

# - Dotfiles already skipped automatically
# Enable by removing the leading '# ' from the next line and editing values.
# filesexcluded: third_party/*, docs/generated/*.md, assets/*.png, scripts/temp_*.py, vendor/lib.js
filesexcluded: .github/*, README.md, Jenkinsfile, Makefile No newline at end of file
Copy link
Preview

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The exclusion pattern '.github/*' will exclude all GitHub workflow files from copyright validation, but the newly added workflow files should probably have copyright headers. Consider being more specific about which GitHub files to exclude.

Suggested change
filesexcluded: .github/*, README.md, Jenkinsfile, Makefile
filesexcluded: .github/ISSUE_TEMPLATE/*, .github/PULL_REQUEST_TEMPLATE/*, .github/FUNDING.yml, README.md, Jenkinsfile, Makefile

Copilot uses AI. Check for mistakes.

@vitalykorolev
Copy link
Collaborator

@SameeraPriyathamTadikonda how can we test this outside of develop branch? Can this be in a feature branch before going to develop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants