Skip to content

PDP-536: Adding copyright check #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+22 −1
Open

PDP-536: Adding copyright check #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .copyrightconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# COPYRIGHT VALIDATION CONFIG
# ---------------------------------
# Required start year (keep fixed; end year auto-updates in check output)
startyear: 2018

# Optional exclusions list (comma-separated). Leave commented if none.
# Rules:
# - Relative paths (no leading ./)
# - Simple * wildcard only (no recursive **)
# - Use sparingly (third_party, generated, binary assets)
# - Dotfiles already skipped automatically
# Enable by removing the leading '# ' from the next line and editing values.
# filesexcluded: third_party/*, docs/generated/*.md, assets/*.png, scripts/temp_*.py, vendor/lib.js
filesexcluded: .github/*, README.md, Jenkinsfile, Makefile
Copy link
Preview

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The exclusion pattern '.github/*' will exclude all GitHub workflow files from copyright validation, but the newly added workflow files should probably have copyright headers. Consider being more specific about which GitHub files to exclude.

Suggested change
filesexcluded: .github/*, README.md, Jenkinsfile, Makefile
filesexcluded: .github/ISSUE_TEMPLATE/*, .github/PULL_REQUEST_TEMPLATE/*, .github/FUNDING.yml, README.md, Jenkinsfile, Makefile

Copilot uses AI. Check for mistakes.

9 changes: 8 additions & 1 deletion .github/workflows/pr-workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: 🏷️ JIRA ID Validator
name: PR Workflow

on:
# Using pull_request_target instead of pull_request to handle PRs from forks
Expand All @@ -14,3 +14,10 @@ jobs:
with:
# Pass the PR title from the event context
pr-title: ${{ github.event.pull_request.title }}
copyright-validation:
name: © Validate Copyright Headers
uses: marklogic/pr-workflows/.github/workflows/copyright-check.yml@main
Comment on lines +17 to +19
Copy link
Preview

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using @main as the workflow reference creates a security risk as it always pulls the latest version without verification. Consider pinning to a specific commit SHA or tagged version for better security and reproducibility.

Copilot uses AI. Check for mistakes.

permissions:
contents: read
pull-requests: write
issues: write