Skip to content

fix(uri): update CSS urls on helpers, macros, tools#518

Open
tristantheb wants to merge 8 commits intomdn:mainfrom
tristantheb:fix/fixing-more-css-link-issues
Open

fix(uri): update CSS urls on helpers, macros, tools#518
tristantheb wants to merge 8 commits intomdn:mainfrom
tristantheb:fix/fixing-more-css-link-issues

Conversation

@tristantheb
Copy link
Member

Description

Additional corrections to CSS page reference links.

Motivation

Apply the same type of correction everywhere and you may be able to reduce more errors in the rari logs at the same time.

Additional details

none

Related issues and pull requests

Related to #508

@tristantheb tristantheb requested a review from a team as a code owner February 3, 2026 19:33
@tristantheb tristantheb requested a review from caugner February 3, 2026 19:33
@tristantheb tristantheb changed the title fix(uri): fixing css references on all files fix(uri): update CSS urls on helpers, macros, tools Feb 3, 2026
@caugner
Copy link
Contributor

caugner commented Feb 3, 2026

Can you take a look at the failing test? If you install lefthook globally, the pre-commit hook will format automatically, and the pre-push hook will run all tests.

Weirdly, according to https://github.com/mdn/rari/actions/runs/21644690912/job/62393559849, this doesn't reduce the number of issues in content. Did you notice these flaws showing up in translated-content PRs, or did you notice these outdated slugs in Rari?

@tristantheb
Copy link
Member Author

I tried pre-correcting errors as a preventive measure and in the hope of correcting strange errors whose origin I cannot find, but if it doesn't change anything, there's no point in continuing with this PR 🤔

Since I was going to fix the broken links anyway, I figured I might as well go all the way with the repository and not just fix the error I originally encountered with CSSInfo. And since CSSSyntax also has some old links, in case there are errors I haven't encountered yet, it might fix errors for other people too ^^'

Unfortunately, I don't have a good enough understanding of Rust to understand all the errors @caugner xD

@caugner
Copy link
Contributor

caugner commented Feb 3, 2026

Unfortunately, I don't have a good enough understanding of Rust to understand all the errors

For the test errors, those are just test expectations that need to be updated:

https://github.com/mdn/rari/actions/runs/21646102034/job/62398552958?pr=518#step:5:1387

For example: https://www.diffchecker.com/4U5Katbc/

For the formatting, you can just run cargo fmt locally.

@tristantheb
Copy link
Member Author

It's really hard to find the error because Windows doesn't give me the same result as GitHub directly (due to the mv command not existing; it's the Orphan part that's causing the error for me). xD

I was able to correct what was possible, but as far as the organization of the <color> | color_value functions is concerned, unfortunately it has an external link/dependency 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants