Redesigned metatensor-based Clebsch Gordan iterations#237
Merged
Conversation
* computation of dense clebsch gordan matrices * passing use_sparse argumentation through whole computation * adding test file that compares output of sparse and dense
Luthaf
reviewed
Nov 20, 2023
Member
Luthaf
left a comment
There was a problem hiding this comment.
small comments, I'll do a full review later
python/rascaline/rascaline/utils/clebsch_gordan/cg_coefficients.py
Outdated
Show resolved
Hide resolved
Member
Author
|
@Luthaf In order to make the CI happy I had to add some dependencies in the min-deps env - for CG tests we need |
Member
yes! https://docs.pytest.org/en/7.1.x/how-to/skipping.html#skipping-on-a-missing-import-dependency |
Luthaf
reviewed
Nov 27, 2023
Member
Author
|
Thanks for the review @Luthaf ! I've made the changes re: your suggestions :) |
Luthaf
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #178 and #185 . New API design for performing metatensor-based Clebsch Gordan iterations.
This PR:
correlate_densityandcorrelate_density_metadata, which perform iterative CG tensor products of a density with itself, returning the a density correlation descriptor of specifiedcorrelation_order, or just the metadata that would wrap it..rstfrom Added cg_utils to Rascaline #185 (@jwa7, @curiosity54, @ecignoni)Not in this PR (see #239):
correlate_tensorsfor doing a single CG product step on 2 arbitrary TensorMaps with the same samplescorrelate_tensors_different_samplesfor doing a single CG product step on 2 arbitrary TensorMaps with different samples.Authored by @jwa7 , @agoscinski , @curiosity54, @frostedoyster , @DivyaSuman14 , @Luthaf , @ecignoni
📚 Documentation preview 📚: https://rascaline--237.org.readthedocs.build/en/237/