Don't always re-train when creating the documentation#797
Closed
johannes-spies wants to merge 3 commits intomainfrom
Closed
Don't always re-train when creating the documentation#797johannes-spies wants to merge 3 commits intomainfrom
johannes-spies wants to merge 3 commits intomainfrom
Conversation
Member
3 tasks
Contributor
|
Is this still necessary? With #854 most of the trainings gets launched inside the example and will be cached. The only one left is the bash example and this is rather quick. |
Contributor
Author
|
If they're cached, I don't see a problem and this PR here can be closed without merging. But does training happen at least once while building the documentation? |
Contributor
|
Yes, when you have no docs, sphinx gallery generates the files and while doing it will call the mtt to perform training via a subprocess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now,
tox -e docsruns some training steps, which can take a long time. This PR adds a switch to skip training and directly builds the docs withTRAIN=0 tox -e docs.📚 Documentation preview 📚: https://metatrain--797.org.readthedocs.build/en/797/