Conversation
PicoCentauri
requested review from
SanggyuChong,
frostedoyster and
johannes-spies
as code owners
PicoCentauri
force-pushed
the
doc-restructure
branch
from
fc2f5b0 to
013bf31
Compare
PicoCentauri
force-pushed
the
doc-restructure
branch
4 times, most recently
from
d0fe58e to
71c6a81
Compare
|
Thanks Philip! Something definitely is still wrong with the rendering, the Tutorials are in 'Tutorials' and in the main tree: |
PicoCentauri
force-pushed
the
doc-restructure
branch
2 times, most recently
from
7563469 to
0be65ea
Compare
Should be fixed. Thanks! |
|
cscs-ci run |
|
cscs-ci run |
|
|
||
| # %% | ||
| # | ||
| # Check outliers with ``Chemiscope`` |
There was a problem hiding this comment.
Not sure why I am getting this here (can you vertify if you also see the same? the original example does not have it, but also does not display the chemiscope image):
There was a problem hiding this comment.
on the web version it render but it also shows the error.
There was a problem hiding this comment.
So this is not a big issue, I would say we could also merge this with the error message for now, since it is still rendering.
Maybe @Luthaf knows how to fix this?
There was a problem hiding this comment.
Can you share the input JSON? Assertion error are always bugs, users should not see them =)
There was a problem hiding this comment.
(we can still merge for sure, I'll see about fixing this on the chemiscope side)
PicoCentauri
force-pushed
the
doc-restructure
branch
3 times, most recently
from
cb2d01b to
b2693e3
Compare
| @@ -15,8 +15,7 @@ mtt --help | |||
| # We now demonstrate how to ``train`` and ``evaluate`` a model from the command line. | |||
| # For this example we use the :ref:`architecture-soap-bpnn` architecture and a subset of | |||
| # the `QM9 dataset <https://paperswithcode.com/dataset/qm9>`_. You can obtain the | |||
There was a problem hiding this comment.
links for me to https://huggingface.co/papers/trending , I would guess we rather want the original qm9 paper? we can also use :doi: to link the paper directly
| ../examples/basic_usage/usage | ||
| custom_dataset_conf | ||
| advanced_base_config | ||
| override |
There was a problem hiding this comment.
the fine-tuning example here should be deleted from this section. Also from my point of view, it looks like it is outdated and can just be completely deleted, maybe @cesaremalosso can you also comment on whether this file can be completely deleted? I think it has been replaced by an example in the beginners section
There was a problem hiding this comment.
hmm but also the fine-tuning in the beginner section links to this.
The reason why I thought it is outdated is that the file refers to a 'fine-tuning example' in the advanced concepts, that does not exist anymore. Can someone from the fine-tuning committee clean this up?
Also, a unified spelling of 'fine-tuning' would be good if this is kept
|
cscs-ci run |
PicoCentauri
force-pushed
the
doc-restructure
branch
from
50497ac to
70ac954
Compare
|
cscs-ci run |
PicoCentauri
force-pushed
the
doc-restructure
branch
from
70ac954 to
7550626
Compare
|
cscs-ci run |
4 participants
All files that are supposed to be rendered as tutorials are now in the
examplessubfolder in the root of the repo. Before, they were all over the place, and we handpicked them... Theexamplesdirectory now contains two subfolders:0-beginnerand1-advanced. Each of them has the tutorials sorted as before. They will be rendered as a nice gallery:The cleaned structure makes it easier to add new tutorials as no per-hand additions to various other files in the
docdirectory are necessary. Sphinx gallery will detect and render them if they are in one of the two subfolders.I also generalised the running of the bash scripts when rendering the docs with tox. Now all
.shfiles in theexamplesdirectory will be run and verified. Also most of the training runs will be now called withsubprocessin each script. This should use caching and speed up when working in the docs. Related to #797Finally, @HannaTuerk suggested renaming the
examplesfolder indocs/srctorendered_examples.TODO
Maintainer/Reviewer checklist
📚 Documentation preview 📚: https://metatrain--854.org.readthedocs.build/en/854/