Skip to content

Remove non-thread-safe code that may lead to crashes when a vector is not found by tag #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
d4mator merged 2 commits into from
Jul 17, 2025
Merged

Remove non-thread-safe code that may lead to crashes when a vector is not found by tag #656

d4mator merged 2 commits into from
Jul 17, 2025

Conversation

@d4mator
Copy link

@d4mator d4mator commented Jul 2, 2025 •
edited
Loading

  • Does this PR have a descriptive title that could go in our release notes?
  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
    • Is the change to the API backwards compatible?
  • Should this result in any changes to our documentation, either updating existing docs or adding new ones?

Reference Issues/PRs

When a vector is not found by tag, disk ANN outputs a message using diskann::cout. It concatenates the message with the tag value, which is not thread safe. in case multiple threads run into this issue, it sometimes leads to a crash.

What does this implement/fix? Briefly explain your changes.

This change remove the offending line and replaces it with returning the error code that the caller will handle.
Also changes to return the vector from the find() instead of using a separate operator[]

Any other comments?

theantony and others added 2 commits January 31, 2025 16:02
@theantony
Comment out non-threadsafe error message output that can cause crashes
7639875 
The method would be called many times per second, so printing an error message
is not appropriate, there's already a return code.
Comment out the non-thread-safe code when vector is not found. Use it…
b9923f2 
…erator instead of operator[] to access the found tag.
@d4mator d4mator merged commit 0a74ed0 into features/taza_base Jul 17, 2025
3 of 7 checks passed
@d4mator d4mator deleted the users/d4mator/get_vector_by_tag branch July 17, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@d4mator @theantony