Skip to content

Remove non-thread-safe code that may lead to crashes when a vector is not found by tag #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d4mator merged 2 commits into from
Jul 17, 2025
Merged

Remove non-thread-safe code that may lead to crashes when a vector is not found by tag #656

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7639875
Comment out non-threadsafe error message output that can cause crashes
theantony Feb 1, 2025
b9923f2
Comment out the non-thread-safe code when vector is not found. Use it…
Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/index.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,13 +794,14 @@ size_t Index<T, TagT, LabelT>::load_graph(std::string filename, size_t expected_
template <typename T, typename TagT, typename LabelT> int Index<T, TagT, LabelT>::get_vector_by_tag(TagT &tag, T *vec)
{
std::shared_lock<std::shared_timed_mutex> lock(_tag_lock);
if (_tag_to_location.find(tag) == _tag_to_location.end())
const auto tagIt = _tag_to_location.find(tag);
if (tagIt == _tag_to_location.end())
{
diskann::cout << "Tag " << tag << " does not exist" << std::endl;
// diskann::cout << "Tag " << tag << " does not exist" << std::endl;
return -1;
}

size_t location = _tag_to_location[tag];
const unsigned location = tagIt->second;
memcpy((void *)vec, (void *)(_data + location * _aligned_dim), (size_t)_dim * sizeof(T));
return 0;
}
Expand Down
Loading