tests: enable bfloat16 support for npy and safetensors#3270
Closed
shivansh023023 wants to merge 1 commit intoml-explore:mainfrom
Closed
tests: enable bfloat16 support for npy and safetensors#3270shivansh023023 wants to merge 1 commit intoml-explore:mainfrom
shivansh023023 wants to merge 1 commit intoml-explore:mainfrom
Conversation
Collaborator
|
Tests not passing, code not doing exactly what it claims, not understanding why we didn't have it in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR addresses the missing
bfloat16testing parity for NPY, NPZ, and Safetensors formats by resolving an existing TODO in python/tests/test_load.py.Changes included:
bfloat16tonp.float32during numpy conversions, allowing test arrays to be properly initialized and validated."bfloat16"to the list of tested dtypes in test_save_and_load, test_save_and_load_fs, and test_savez_and_loadz.bfloat16remains intentionally excluded from test_save_and_load_gguf, as the C++ backend does not yet support it for the GGUF format.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes