Skip to content

tests: enable bfloat16 support for npy and safetensors #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shivansh023023 wants to merge 1 commit into from
Closed

tests: enable bfloat16 support for npy and safetensors #3270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions python/tests/test_load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
import numpy as np


def _to_np_dtype(dt):
return np.float32 if dt == "bfloat16" else getattr(np, dt)


class TestLoad(mlx_tests.MLXTestCase):
dtypes = [
"uint8",
Expand Down Expand Up @@ -38,16 +42,16 @@ def tearDownClass(cls):
cls.test_dir_fid.cleanup()

def test_save_and_load(self):
for dt in self.dtypes:
for dt in self.dtypes + ["bfloat16"]:
with self.subTest(dtype=dt):
for i, shape in enumerate([(1,), (23,), (1024, 1024), (4, 6, 3, 1, 2)]):
with self.subTest(shape=shape):
save_file_mlx = os.path.join(self.test_dir, f"mlx_{dt}_{i}.npy")
save_file_npy = os.path.join(self.test_dir, f"npy_{dt}_{i}.npy")

save_arr = np.random.uniform(0.0, 32.0, size=shape)
save_arr_npy = save_arr.astype(getattr(np, dt))
save_arr_mlx = mx.array(save_arr_npy)
save_arr_npy = save_arr.astype(_to_np_dtype(dt))
save_arr_mlx = mx.array(save_arr_npy, dtype=getattr(mx, dt))

mx.save(save_file_mlx, save_arr_mlx)
np.save(save_file_npy, save_arr_npy)
Expand Down Expand Up @@ -304,7 +308,7 @@ def test_save_and_load_fs(self):
if not os.path.isdir(self.test_dir):
os.mkdir(self.test_dir)

for dt in self.dtypes:
for dt in self.dtypes + ["bfloat16"]:
with self.subTest(dtype=dt):
for i, shape in enumerate([(1,), (23,), (1024, 1024), (4, 6, 3, 1, 2)]):
with self.subTest(shape=shape):
Expand All @@ -316,8 +320,8 @@ def test_save_and_load_fs(self):
)

save_arr = np.random.uniform(0.0, 32.0, size=shape)
save_arr_npy = save_arr.astype(getattr(np, dt))
save_arr_mlx = mx.array(save_arr_npy)
save_arr_npy = save_arr.astype(_to_np_dtype(dt))
save_arr_mlx = mx.array(save_arr_npy, dtype=getattr(mx, dt))

with open(save_file_mlx, "wb") as f:
mx.save(f, save_arr_mlx)
Expand All @@ -342,7 +346,7 @@ def test_savez_and_loadz(self):
if not os.path.isdir(self.test_dir):
os.mkdir(self.test_dir)

for dt in self.dtypes:
for dt in self.dtypes + ["bfloat16"]:
with self.subTest(dtype=dt):
shapes = [(6,), (6, 6), (4, 1, 3, 1, 2)]
save_file_mlx_uncomp = os.path.join(
Expand All @@ -358,10 +362,13 @@ def test_savez_and_loadz(self):
save_arrs_npy = {
f"save_arr_{i}": np.random.uniform(
0.0, 32.0, size=shapes[i]
).astype(getattr(np, dt))
).astype(_to_np_dtype(dt))
for i in range(len(shapes))
}
save_arrs_mlx = {k: mx.array(v) for k, v in save_arrs_npy.items()}
save_arrs_mlx = {
k: mx.array(v, dtype=getattr(mx, dt))
for k, v in save_arrs_npy.items()
}

# Save as npz files
np.savez(save_file_npy_uncomp, **save_arrs_npy)
Expand Down
Loading