Refactor: Split COCO dataset into detection and segmentation datasets#280
Conversation
…ory reduction and better UX (Breaking: segmentation users migrate to coco_segmentation_dataset)
|
Hello @Chandraveersingh1717, Thansk a lot for this contribution ! It actually fix #171 ! (And sorry for the delay to review it, I miss the notification) |
cregouby
left a comment
There was a problem hiding this comment.
Hello @Chandraveersingh1717
praise thanks a lot for this contribution
todo missing Would you add your name to the contributor list in DESCRIPTION file ?
todo documentation Documentation of the package is not up-to-date with your changes in roxygen2. Please perform a devtools::document() and resubmit Rd files
todo R CMD CHECK fails, and should be fixed.
suggestion You can see the R CMD CHECK failures in the CI/CD pipeline logs ("checks" tab in github) but you can see them performing a local devtools::check()
todo please remove all unexpected files at package top folder. (as per
❯ checking top-level files ... NOTE
Non-standard files/directories found at top level:
‘test_coco_changes.R’ ‘tiny_meta.json’ ‘tiny_meta.ndjson’
todo Please mention you are using a LLM if any in the NEWS
|
|
||
| ## New datasets | ||
|
|
||
| * Added `vggface2_dataset()` for loading the VGGFace2 dataset (@DerrickUnleashed, #238). |
There was a problem hiding this comment.
todo please do not remove actual news
|
Thanks a lot ! |
Summary
Split
coco_detection_dataset()into two specialized datasets for object detection and instance segmentation tasks.Problem
Solution
coco_detection_dataset()- Object Detection Onlycoco_segmentation_dataset()- Instance Segmentation (NEW)Cache Organization: Files now stored in
/cocosubdirectory for better identificationBreaking Change
Segmentation users must migrate: