feat: allow user to pass multiple files to fix and check commands#1921
feat: allow user to pass multiple files to fix and check commands#1921sinrohit-desco wants to merge 3 commits intomolybdenumsoftware:masterfrom
Conversation
|
Would you mind adding some tests, please? |
Sorry, I have added I forgot to push and also resolving the conflicts |
mightyiam
left a comment
mightyiam
left a comment
There was a problem hiding this comment.
Q: what's one minimal precursor refactor that could be extracted from this total change? If there is one, perhaps extracting it into its own commit would make this easier to review?
|
Is the file discovery and ignoring behavior tested at the moment? If not, I think it should be, as a precursor PR. What do you think? |
I had tested this change myself and we have been using this change in our org for a few months now, so I would like to say that it is tested. |
Replace hand-rolled Walker iterator and build_ignore_set with ignore::WalkBuilder from the same ignore crate. Earlier we were using ignore::gitignore API for pattern matching and a custom Walker struct for directory traversal. WalkBuilder combines both — it walks directories and applies gitignore rules.
mightyiam
left a comment
mightyiam
left a comment
There was a problem hiding this comment.
Hrm... what do you think of this plan:
- PR that replaces existing file matching implementation with the use of a library.
- PR that adds support for multiple files
?
2 participants
Resolves oppiliappan#118