-
Notifications
You must be signed in to change notification settings - Fork 916
GODRIVER-3632: Reroute to use perfcomp from DET #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🧪 Performance ResultsCommit SHA: 79e131eThe following benchmark tests for version 68a362f8e45e930007b9ab6f had statistically significant changes (i.e., |z-score| > 1.96):
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
API Change ReportNo changes found! |
92a6021
to
6a33311
Compare
a4e3a8d
to
79e131e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the performance comparison functionality from a local implementation in the Go Driver repository to using the centralized perfcomp tool from drivers-evergreen-tools.
- Remove the entire perfcomp directory and its Go modules from the Go Driver
- Update the shell script to use the external perfcomp tool from drivers-evergreen-tools
- Adjust file paths and working directories to accommodate the new external tool location
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
internal/cmd/perfcomp/mdreport.go | Removes the markdown report generation functionality |
internal/cmd/perfcomp/main.go | Removes the main CLI entry point for perfcomp |
internal/cmd/perfcomp/go.mod | Removes the Go module definition for perfcomp |
internal/cmd/perfcomp/energystatistics_test.go | Removes energy statistics unit tests |
internal/cmd/perfcomp/compare.go | Removes the core performance comparison logic and MongoDB analytics integration |
etc/perf-pr-comment.sh | Updates script to use external perfcomp tool and adjusts file paths |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
||
# Generate perf report. | ||
GOWORK=off ./bin/perfcomp compare --project="mongo-go-driver" ${VERSION_ID} > ./internal/cmd/perfcomp/perf-report.txt | ||
pushd $DRIVERS_TOOLS/.evergreen >/dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $DRIVERS_TOOLS is used without quotes, which could cause issues if the path contains spaces or special characters. Consider using "$DRIVERS_TOOLS" instead.
pushd $DRIVERS_TOOLS/.evergreen >/dev/null | |
pushd "$DRIVERS_TOOLS/.evergreen" >/dev/null |
Copilot uses AI. Check for mistakes.
GODRIVER-3632
Summary
drivers-evergreen-tools
Background & Motivation
Pilot perf comparison PR comment tool for drivers.