Skip to content

GODRIVER-3632: Reroute to use perfcomp from DET #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
Merged

GODRIVER-3632: Reroute to use perfcomp from DET #2163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7a0cf1
Reroute shell script to use DET perfcomp
zhouselena Aug 18, 2025
79e131e
Remove local perfcomp
zhouselena Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions etc/perf-pr-comment.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,17 @@

set -eux

pushd ./internal/cmd/perfcomp >/dev/null || exist
GOWORK=off go build -o ../../../bin/perfcomp .
popd >/dev/null

# Generate perf report.
GOWORK=off ./bin/perfcomp compare --project="mongo-go-driver" ${VERSION_ID} > ./internal/cmd/perfcomp/perf-report.txt
pushd $DRIVERS_TOOLS/.evergreen >/dev/null
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $DRIVERS_TOOLS is used without quotes, which could cause issues if the path contains spaces or special characters. Consider using "$DRIVERS_TOOLS" instead.

Suggested change
pushd $DRIVERS_TOOLS/.evergreen >/dev/null
pushd "$DRIVERS_TOOLS/.evergreen" >/dev/null

Copilot uses AI. Check for mistakes.

PROJECT="mongo-go-driver" CONTEXT="GoDriver perf task" TASK="perf" VARIANT="perf" sh run-perf-comp.sh

if [[ -n "${BASE_SHA+set}" && -n "${HEAD_SHA+set}" && "$BASE_SHA" != "$HEAD_SHA" ]]; then
# Parse and generate perf comparison comment.
GOWORK=off ./bin/perfcomp mdreport
# Make the PR comment.
target=$DRIVERS_TOOLS/.evergreen/github_app/create_or_modify_comment.sh
bash $target -m "## 🧪 Performance Results" -c "$(pwd)/perf-report.md" -h $HEAD_SHA -o "mongodb" -n "mongo-go-driver"
rm ./perf-report.md
target=github_app/create_or_modify_comment.sh
bash $target -m "## 🧪 Performance Results" -c "$(pwd)/perfcomp/perf-report.md" -h $HEAD_SHA -o "mongodb" -n "mongo-go-driver"
rm ./perfcomp/perf-report.md
else
# Skip comment if it isn't a PR run.
echo "Skipping Perf PR comment"
fi

rm ./internal/cmd/perfcomp/perf-report.txt
popd >/dev/null
Loading
Loading