Skip to content

Fix compile Warning/Error (tf2*.h is deprecated)#3562

Closed
mosfet80 wants to merge 1 commit intomoveit:mainfrom
mosfet80:fixTf2Deprecations
Closed

Fix compile Warning/Error (tf2*.h is deprecated)#3562
mosfet80 wants to merge 1 commit intomoveit:mainfrom
mosfet80:fixTf2Deprecations

Conversation

@mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented Aug 22, 2025

Description

*.h headers is deprecated into tf2 libs . -> switch to *.hpp headers
ros2/geometry2@a99d88b

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (4fc5c82) to head (0cb865f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3562      +/-   ##
========================================
  Coverage   0.00%   0.00%              
========================================
  Files        180     407     +227     
  Lines      22601   37534   +14933     
  Branches    3099    5163    +2064     
========================================
- Misses     22601   37534   +14933     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mosfet80
Copy link
Contributor Author

mosfet80 commented Sep 1, 2025

[fix] https://github.com/moveit/moveit2/actions/runs/16860502228/job/47759979767
/opt/ros/rolling/include/tf2_ros/tf2_ros/buffer.h:40:4: error: BUFFER_HEADER_DEPRECATION [-Werror,-W#warnings]
40 | #warning BUFFER_HEADER_DEPRECATION
| ^
1 error generated.

@mosfet80 mosfet80 changed the title Fix compile warning (tf2*.h is deprecated) Fix compile Warning/Error (tf2*.h is deprecated) Sep 1, 2025
@nbbrooks
Copy link
Contributor

nbbrooks commented Sep 3, 2025

This looks close!

There are some remaining image_transport deprecation issues causing the build failure:

https://github.com/moveit/moveit2/actions/runs/17156371898/job/48674102778?pr=3562#step:11:2747

@nbbrooks
Copy link
Contributor

nbbrooks commented Sep 3, 2025

I pulled in your commit into a test PR here looking for fix qos api deprecations due to things like ros-perception/image_common#364

Once we get it passing perhaps you can pick my changes into your PR here so we can get some green lights on CI.

@nbbrooks
Copy link
Contributor

nbbrooks commented Sep 8, 2025

@mosfet80 I ended up needing to do a bit more cleanup and addressed several other rolling deprecations. To keep the history in one place I am going to merge #3567 instead but keep your original commit in the history.

*.h headers is deprecated into tf2 libs . -> switch to *.hpp headers
@mosfet80
Copy link
Contributor Author

included into #3567

@mosfet80 mosfet80 closed this Oct 20, 2025
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Oct 20, 2025
@mosfet80 mosfet80 mentioned this pull request Oct 20, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants