CRINGE-225: Use docker compose instead of just to build containers.#208
CRINGE-225: Use docker compose instead of just to build containers.#208
docker compose instead of just to build containers.#208Conversation
biancadanforth
left a comment
biancadanforth
left a comment
There was a problem hiding this comment.
This has a typo that would break the script when it runs, but I'm R+WC rather than requesting changes to avoid another review cycle.
Also wondering if we should include the --progress plain option as in the just build recipe equivalent.
| - name: Build docker images for publishing | ||
| run: | | ||
| just build fakesentry gcs-emulator | ||
| docker comppose build fakesentry gcs-emulator |
There was a problem hiding this comment.
s/comppose/compose
Also, the exact just build recipe is docker compose --progress plain build {{args}}. I'm not sure what the default is, but we probably want plain here?
There was a problem hiding this comment.
I think the default is auto, which detects whether stdout is a terminal and then picks either tty or plain. In GitHub Actions, standard out is not a terminal, so it will pick plain.
There was a problem hiding this comment.
(I just reverted my ill-advised change to this line from #203. It was fine before, so it should be fine now.)
2 participants
We don't install
justin the release workflow, so calling it fails. We could install it, but it doesn't seem worth it just for that one command that's not really more complex when called directly.