Skip to content

CRINGE-225: Use docker compose instead of just to build containers. #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarnach merged 1 commit into from
Mar 19, 2026
Merged

CRINGE-225: Use docker compose instead of just to build containers. #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
run: uv build --wheel
- name: Build docker images for publishing
run: |
just build fakesentry gcs-emulator
docker comppose build fakesentry gcs-emulator
Copy link
Copy Markdown
Contributor

@biancadanforth biancadanforth Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/comppose/compose

Also, the exact just build recipe is docker compose --progress plain build {{args}}. I'm not sure what the default is, but we probably want plain here?

Copy link
Copy Markdown
Contributor Author

@smarnach smarnach Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default is auto, which detects whether stdout is a terminal and then picks either tty or plain. In GitHub Actions, standard out is not a terminal, so it will pick plain.

Copy link
Copy Markdown
Contributor Author

@smarnach smarnach Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I just reverted my ill-advised change to this line from #203. It was fine before, so it should be fine now.)

GAR_REPO="us-docker.pkg.dev/${{ secrets.GCP_PROJECT_ID }}/cavendish-prod"
FAKESENTRY_TAG="$GAR_REPO/fakesentry:${{ env.RELEASE_TAG }}"
docker tag local/obs-common-fakesentry:latest "$FAKESENTRY_TAG"
Expand Down