fix(views): remove unused defaultModel declaration in model-picker#1884
Closed
james-heidi wants to merge 1 commit intomultica-ai:mainfrom
Closed
fix(views): remove unused defaultModel declaration in model-picker#1884james-heidi wants to merge 1 commit intomultica-ai:mainfrom
james-heidi wants to merge 1 commit intomultica-ai:mainfrom
Conversation
Commit 55b7e2e dropped the only consumer of `defaultModel` (the `triggerLabel` expression) but left the `useMemo` declaration in place, which fails `tsc --noEmit` with TS6133 and red-CI's any downstream branch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@james-heidi is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
3 tasks
Author
|
Superseded by #1878 — Multica Eve landed the same one-line removal (with a slightly tighter comment) at 12:35 UTC, before this PR could get a maintainer review. Closing to avoid the now-redundant conflict; nothing to merge. Side effect: the take-command PR #1880 was conflicting on the same lines because james-heidi/main hadn't picked up #1878 yet. I've merged upstream/main into james-heidi/main (taking the upstream comment wording), pushed the merge, and #1880 now reports MERGEABLE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes a now-unused
defaultModeluseMemodeclaration inpackages/views/agents/components/inspector/model-picker.tsxthat was orphaned by #1875. Restorestsc --noEmit(and CI) to green.Related Issue
Caused by #1875. Surfaced as a CI failure on #1880; fixing here unblocks both
mainand any open PR that gets the merged tree.Type of Change
Changes Made
packages/views/agents/components/inspector/model-picker.tsx— drop the orphanedconst defaultModel = useMemo(...). The sibling change in fix(views): stop showing hardcoded model name in default model display #1875 already deleted the declaration inmodel-dropdown.tsx; this is the missing half. Updated the adjacent comment so it no longer references the removed binding.How to Test
Should exit cleanly. Before this change it fails with:
No runtime behavior change —
defaultModelwas already unused after #1875.Checklist
pnpm --filter @multica/views typecheckclean)AI Disclosure
AI tool used: Claude Code (Opus 4.7).
Prompt / approach: Diagnosed CI failure on #1880, traced the unused-variable error to commit 55b7e2e which removed the consumer (
triggerLabel) but left the declaration. Removed the declaration and refreshed the surrounding comment.Screenshots (optional)
N/A.