feat(views): add left sidebar collapse option for desktop#1973
Open
forrestchang wants to merge 3 commits intomainfrom
Open
feat(views): add left sidebar collapse option for desktop#1973forrestchang wants to merge 3 commits intomainfrom
forrestchang wants to merge 3 commits intomainfrom
Conversation
Show a sidebar toggle button in the page header when the sidebar is collapsed on desktop, and add a toggle button to the sidebar footer for collapsing. Also adds Cmd+B / Ctrl+B keyboard shortcut to toggle the sidebar. Closes #1967 Co-authored-by: multica-agent <github@multica.ai>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Skip the sidebar toggle when focus is inside INPUT, TEXTAREA, SELECT, or contentEditable elements so the shortcut does not steal Cmd+B (bold) from TipTap editors. Co-authored-by: multica-agent <github@multica.ai>
Co-authored-by: multica-agent <github@multica.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cmd+B/Ctrl+Bkeyboard shortcut to toggle the sidebar (standard convention used by VS Code, Linear, etc.)Closes #1967
Changes
packages/ui/components/ui/sidebar.tsx— Added keyboard shortcut handler inSidebarProviderpackages/views/layout/page-header.tsx— MadeSidebarTriggervisible on desktop when sidebar is collapsed (wasmd:hidden)packages/views/layout/app-sidebar.tsx— AddedSidebarTriggerto sidebar footer next to help buttonTest plan
Cmd+B(Mac) /Ctrl+B(Windows/Linux) to toggle sidebar