Skip to content

feat(views): add left sidebar collapse option for desktop #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
forrestchang wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −5
Open

feat(views): add left sidebar collapse option for desktop #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f08097
feat(views): add left sidebar collapse option for desktop
forrestchang May 1, 2026
fc8ddc9
fix(ui): guard Cmd+B sidebar shortcut against editable elements
forrestchang May 1, 2026
2ff9ad0
refactor(ui): remove Cmd+B sidebar toggle keyboard shortcut
forrestchang May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/views/layout/app-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ import {
SidebarMenuButton,
SidebarMenuItem,
SidebarRail,
SidebarTrigger,
} from "@multica/ui/components/ui/sidebar";
import {
DropdownMenu,
Expand Down Expand Up @@ -691,7 +692,8 @@ export function AppSidebar({ topSlot, searchSlot, headerClassName, headerStyle }
</SidebarContent>

<SidebarFooter className="p-2">
<div className="flex justify-end">
<div className="flex items-center justify-between">
<SidebarTrigger />
<HelpLauncher />
</div>
</SidebarFooter>
Expand Down
9 changes: 5 additions & 4 deletions packages/views/layout/page-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
import { cn } from "@multica/ui/lib/utils";
import { SidebarTrigger, useSidebar } from "@multica/ui/components/ui/sidebar";

function MobileSidebarTrigger() {
function SidebarToggle() {
try {
useSidebar();
const { state } = useSidebar();
// On mobile: always show (hamburger). On desktop: only when sidebar is collapsed.
return <SidebarTrigger className={cn("mr-2", state === "expanded" && "md:hidden")} />;
} catch {
return null;
}
return <SidebarTrigger className="mr-2 md:hidden" />;
}

interface PageHeaderProps {
Expand All @@ -20,7 +21,7 @@ interface PageHeaderProps {
export function PageHeader({ children, className }: PageHeaderProps) {
return (
<div className={cn("flex h-12 shrink-0 items-center border-b px-4", className)}>
<MobileSidebarTrigger />
<SidebarToggle />
{children}
</div>
);
Expand Down
Loading