Open
Conversation
minhphd
commented
Feb 28, 2023
- added rotation and generated new lexicon file
- created a lexicon to csv converter script for reading and debugging lexicon file
- tested new lexicon file with test1.py
Owner
|
Nice work @minhphd, thanks for making a contribution to this project. Here are a few comments that I have: It seems like you are taking the average congruence of all rotations, which makes most values around 0.5. Can you change that to the maximum value, as suggested by the methods section of this paper (2nd paragraph): In the same paper you can find a table of letter congruence, it would be great if you can compare the values in the tables to your generated values. They don't have to match perfectly, but they should be correlated. I will accept the PR with the updates above. Feel free to send me a nudge if you want me to take a look at this. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.