-
Notifications
You must be signed in to change notification settings - Fork 9
GQL-113: Add new GraphQL query type for Citation #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
}) | ||
|
||
const { data, errors } = response.body.singleResult | ||
console.log("🚀 ~ test ~ errors:", errors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug
src/cmr/concepts/citation.js
Outdated
getPermittedJsonSearchParams() { | ||
return [ | ||
...super.getPermittedJsonSearchParams(), | ||
'author-name', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to confirm the hyphens are intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be _
. Fixed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 112 +3
Lines 2509 2551 +42
Branches 287 288 +1
=========================================
+ Hits 2509 2551 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/** | ||
* Returns an array of keys representing supported search params for the json endpoint | ||
*/ | ||
getPermittedJsonSearchParams() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are you getting this list of values? I can't find documentation on what search params are supported. I can't find any CMR documentation on citations, only drafts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got these values from CMR Repo. CMR is missing the documentation for Citation
, I filed a ticket to have documentation added: https://bugs.earthdata.nasa.gov/browse/CMR-10583
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
src/cmr/concepts/citation.js
Outdated
fetchUmm(searchParams, ummKeys, headers) { | ||
const ummHeaders = { | ||
...headers, | ||
Accept: 'application/vnd.nasa.cmr.umm_results+json' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have a version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
Overview
What is the feature?
Adds citation and citation draft
What areas of the application does this impact?
New queries and mutations for Citations
Testing
Checklist