Conversation
Bump to v1.7.1dev
Important! Template update for nf-core/tools v3.5.1
…tion Update FASTP module
Samshee should only validate samplesheet, but we still want BCLconvert to run on the original samplesheet. This is for the following reasons: * avoid potential bugs in samshee - if there are any and this leads to a validation error no big harm is done. If it incorrectly rewrites a samplesheet that would be bad * easier debugging: we just had such a case where BCLconvert failed on the raw samplesheet but passed on the samshee-formatted one. Took a while to figure out what's going on.
Use unformatted samplesheet for BCLconvert
replace functions tests (`nextflow_workflow`) for `nextflow_function`
|
apeltzer
reviewed
Apr 16, 2026
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## v1.7.0 | ||
| ## 1.7.1 - 2026-04-20 |
Member
There was a problem hiding this comment.
Suggested change
| ## 1.7.1 - 2026-04-20 | |
| ## 1.7.1 - 2026-04-16 |
apeltzer
approved these changes
Apr 16, 2026
Member
apeltzer
left a comment
apeltzer
left a comment
There was a problem hiding this comment.
LGTM :-) @julianSchwab is running some tests right now
atrigila
requested review from
a team,
blajoie,
nh13 and
sam-white04
as code owners
Update changelog
|
Looks good to me, too! Demux runs through fine, MultiQC SAV is there. |
julianSchwab
approved these changes
Apr 17, 2026
julianSchwab
left a comment
julianSchwab
left a comment
There was a problem hiding this comment.
I checked the changes and compared the results for a flowcell already demuxed with a previous version. Looks good to me as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #382
1.7.1
AddedChangedUTILS.groovyFixedDependencies