add samplesheet for full plate test#2018
Merged
rboz1 merged 3 commits intonf-core:cellpaintingfrom Apr 29, 2026
Merged
Conversation
mashehu
reviewed
Apr 28, 2026
Contributor
There was a problem hiding this comment.
These it quite big, we usually prefer files <1mb if possible. Is even for a full test such a big sample sheet needed?
Author
|
Yeah, agreed. I think this would take a long time to run just as a test
too. I could do ¼ of it? Then it’d be larger than the minimal test with 3
wells but not massive.
…On Tue, Apr 28, 2026 at 4:08 PM Matthias Hörtenhuber < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On complete_plate_dataset/samplesheet_test_full.csv
<#2018 (comment)>
:
These it quite big, we usually prefer files <1mb if possible. Is even for
a full test such a big sample sheet needed?
—
Reply to this email directly, view it on GitHub
<#2018 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APCSXLPR57VOE3EZS5RLTSL4YEFUDAVCNFSM6AAAAACYJ26DVWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DCOJSGAZDQMRTGQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
kenibrewer
approved these changes
Apr 29, 2026
Member
kenibrewer
left a comment
kenibrewer
left a comment
There was a problem hiding this comment.
One minor change. Otherwise great.
Member
There was a problem hiding this comment.
Let's delete this file, otherwise this is great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.