Closed
Conversation
Collaborator
Author
|
Incorporated the only chunk that seems to still matter into #571. Open question on the prefix remains, but we can clean that up later if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered two problems debugging MQTT not getting data in my environment:
self.__masterthrows an exception trying to call any methods on the object, but renaming it toself.masterworks. I'm mystified why.This is my attempt at fixing it. However, I don't run with any non-default prefix, so I'm not certain it's right. I just know it is working for me when not setting a prefix in either Teslamate or TWCManager.
However, it occurs to me that anyone who has it working probably does so by setting "teslamate" as their prefix. Do you think we should treat "teslamate" as equivalent to None? That messes up anyone who's actually using "teslamate" as their prefix in a Teslamate instance, but I don't know why one would.