Conversation
|
I took a quick look and these changes are not compatible with paho mqtt client v2 and the MQTTv5 protocol. So this PR will probably only work for installs that are still using paho mqtt client v1. I will fix this when I have more time. |
|
It turned out to be an easy fix, see RichieB2B@69027ca and the paho migration documentation for reference. |
|
Incorporated -- thank you! |
|
Looks good, thanks @MikeBishop and @RichieB2B |
|
I tried this merged into my working branch (main + some PRs) and it seems to be working. Appreciate it if someone else can give it a try before we merge. |
|
There is a small conflict in this branch for the definition of There is a small issue with the When I run this code, it polls |
|
When a car is charging, |
|
@MikeBishop Can you rebase to main and address the above issues? Seems ready to merge after that. |
|
How's that? |
|
Looks good to me! |
|
And as an added benefit, the names do match up automatically, because of the 30-second delay on setting up MQTT. We've already found the display_name from the API before we get the first events from the MQTT server. |
|
@ngardiner, @RichieB2B any objections to merging? |
|
I've been running this code for 3 weeks now. Looks ready to merge to me. |
This PR attempts to pull out all the MQTT-related changes from #483, other than #492. This without #492 might be somewhat inconsistent.
Draft because I haven't explicitly tested this yet, just done the work in git to lift it out.