Skip to content

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented Nov 14, 2025

Proposed changes

Update Labels Regex to allow . so that product version can be sent as labels
Expand unit tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Nov 14, 2025
@aphralG aphralG requested a review from a team as a code owner November 14, 2025 15:12
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.30%. Comparing base (34a13e6) to head (1a4204a).
⚠️ Report is 1 commits behind head on release-3.5.1.

Additional details and impacted files
@@                Coverage Diff                @@
##           release-3.5.1    #1390      +/-   ##
=================================================
- Coverage          86.41%   86.30%   -0.11%     
=================================================
  Files                102      102              
  Lines              12585    12585              
=================================================
- Hits               10875    10862      -13     
- Misses              1233     1248      +15     
+ Partials             477      475       -2     
Files with missing lines Coverage Δ
internal/config/config.go 87.23% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a13e6...1a4204a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhurley dhurley merged commit 6970629 into release-3.5.1 Nov 18, 2025
35 checks passed
@dhurley dhurley deleted the update-label-regex branch November 18, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants