Skip to content

Update Label Validation #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
+51 −1
Merged

Update Label Validation #1390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1b1b8a
fix label regex
aphralG Nov 14, 2025
1a4204a
PR feedback - add unit test
aphralG Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const (
// Regular expression to match invalid characters in paths.
// It matches whitespace, control characters, non-printable characters, and specific Unicode characters.
regexInvalidPath = "\\s|[[:cntrl:]]|[[:space:]]|[[^:print:]]|ㅤ|\\.\\.|\\*"
regexLabelPattern = "^[a-zA-Z0-9]([a-zA-Z0-9-_]{0,254}[a-zA-Z0-9])?$"
regexLabelPattern = "^[a-zA-Z0-9]([a-zA-Z0-9-_.]{0,254}[a-zA-Z0-9])?$"
)

var viperInstance = viper.NewWithOptions(viper.KeyDelimiter(KeyDelimiter))
Expand Down
50 changes: 50 additions & 0 deletions internal/config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1559,6 +1559,56 @@ func TestValidateLabel(t *testing.T) {
input: "label 123",
expected: false,
},
{
name: "Test 9: Valid label - cluster id",
input: "73623aef-1d5b-4f6b-b73d-5561c36851cc",
expected: true,
},
{
name: "Test 10: Valid label - installation name",
input: "my-release-nginx-ingress-controller",
expected: true,
},
{
name: "Test 11: Valid label - product",
input: "nic",
expected: true,
},
{
name: "Test 12: Valid label - version",
input: "5.3.0",
expected: true,
},
{
name: "Test 13: Valid label - version snapshot",
input: "5.3.0-SNAPSHOT",
expected: true,
},
{
name: "Test 14: Invalid label - newlines",
input: "label-2\n\n",
expected: false,
},
{
name: "Test 15: Valid label - only numbers",
input: "1234567",
expected: true,
},
{
name: "Test 16: Invalid label - start and end with .",
input: ".label.",
expected: false,
},
{
name: "Test 17: Invalid label - lots of blank spaces",
input: " label",
expected: false,
},
{
name: "Test 18: Invalid label - start and end with blank space",
input: " label ",
expected: false,
},
}

for _, tt := range tests {
Expand Down
Loading