Open
Conversation
reckenro
commented
Apr 2, 2026
reckenro
commented
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Validate MI driver hapigen proto generation fix.
Hapigen proto generation wasn't using sorted keys for
functions,enums, etc.This was leading to a discrepancy in the ordering of things in the proto file coming from hapigen and the one generated on the grpc-device side.
https://dev.azure.com/ni/DevCentral/_git/ni-central/pullrequest/1224177 fixes this on the hapigen side.
Why should this Pull Request be merged?
This PR validates the MI driver hapigen fixes with ni-fake.
It takes in the new ni-fake metadata + proto generated by hapigen and validates it works with the service.
What testing has been done?
Service builds and nifake tests pass.
Visually inspected new nifake from hapigen proto to validate that rpc, enums, etc. are sorted alphabetically.
In previous nifake hapigen exports, these weren't sorted.
Also validated with
validate_imported_protosstep that validates the nifake proto from hapigen with the one produced here in grpc-device.