Skip to content

Support flat eslint configuration format for nimble packages#2768

Closed
gokulprasanth-ni wants to merge 8 commits intomainfrom
users/gokulprasanthRavi/feat/update-nimble-eslint-to-flat-config
Closed

Support flat eslint configuration format for nimble packages#2768
gokulprasanth-ni wants to merge 8 commits intomainfrom
users/gokulprasanthRavi/feat/update-nimble-eslint-to-flat-config

Conversation

@gokulprasanth-ni
Copy link
Copy Markdown
Contributor

Pull Request

🤨 Rationale

  • Update nimble packages to use flat eslint configuration format and upgrade to eslint v9.

👩‍💻 Implementation

  • Updated nimble packages to use flat eslint configuration and upgrade to eslint v9.
  • Fixed the linting issue as per the new version of javascript-styleguide packages.

🧪 Testing

  • Ran the linting command and it got passed.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
…slint-to-flat-config

Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
@gokulprasanth-ni gokulprasanth-ni changed the title [Draft] Support flat eslint configuration format for nimble packages Support flat eslint configuration format for nimble packages Dec 1, 2025
@gokulprasanth-ni gokulprasanth-ni marked this pull request as ready for review December 1, 2025 12:24
@rajsite rajsite marked this pull request as draft December 1, 2025 18:25
@@ -0,0 +1,7 @@
{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi owners, I'm making some changes to the PR and will move it back out of draft when reviewed

@rajsite
Copy link
Copy Markdown
Member

rajsite commented Dec 3, 2025

Closing in favor of #2773 and #2774
Thank you so much @gokulprasanth-ni for getting to the point where linting was passing! There were some additional nimble repo-specific changes to handle in the alternate PRs but it was a huge help to start with something already working.

@rajsite rajsite closed this Dec 3, 2025
@rajsite rajsite deleted the users/gokulprasanthRavi/feat/update-nimble-eslint-to-flat-config branch January 16, 2026 05:38
@rajsite rajsite restored the users/gokulprasanthRavi/feat/update-nimble-eslint-to-flat-config branch January 16, 2026 05:38
@rajsite rajsite deleted the users/gokulprasanthRavi/feat/update-nimble-eslint-to-flat-config branch January 20, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants