-
Notifications
You must be signed in to change notification settings - Fork 11
Support flat eslint configuration format for nimble packages #2768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
gokulprasanth-ni
wants to merge
8
commits into
main
from
users/gokulprasanthRavi/feat/update-nimble-eslint-to-flat-config
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fc90386
update nimble eslint to flat config format
gokulprasanth-ni 7a69794
Change files
gokulprasanth-ni 377c6fd
fix: lint
gokulprasanth-ni ea326a3
Merge branch 'main' into users/gokulprasanthRavi/feat/update-nimble-e…
gokulprasanth-ni d6d4a1c
revert lock
gokulprasanth-ni 5fd00d1
update code
gokulprasanth-ni e14b62b
Merge remote-tracking branch 'origin/main' into users/gokulprasanthRa…
rajsite 5186dd8
Update package-lock.json
rajsite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@ni-jasmine-parameterized-6c99369c-d30b-42ad-a468-fe1ff92ddb2c.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Upgrade to ESLint v9 and update the configuration to use the flat configuration format", | ||
| "packageName": "@ni/jasmine-parameterized", | ||
| "email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } | ||
7 changes: 7 additions & 0 deletions
7
change/@ni-nimble-angular-937e837a-be00-4a16-903c-eeb28cb80ece.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Upgrade to ESLint v9 and update the configuration to use the flat configuration format", | ||
| "packageName": "@ni/nimble-angular", | ||
| "email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@ni-nimble-components-e929d5b5-c2c0-4bad-806d-11da32c128a1.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Upgrade to ESLint v9 and update the configuration to use the flat configuration format", | ||
| "packageName": "@ni/nimble-components", | ||
| "email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@ni-nimble-react-e8da0210-a00f-4054-9cbf-b71956d06c73.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Upgrade to ESLint v9 and update the configuration to use the flat configuration format", | ||
| "packageName": "@ni/nimble-react", | ||
| "email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@ni-nimble-tokens-a1709922-af92-4354-abd5-8c978855ec81.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Upgrade to ESLint v9 and update the configuration to use the flat configuration format", | ||
| "packageName": "@ni/nimble-tokens", | ||
| "email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@ni-ok-angular-b7bd1dbd-32e4-4feb-a577-b0888cc9b400.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Upgrade to ESLint v9 and update the configuration to use the flat configuration format", | ||
| "packageName": "@ni/ok-angular", | ||
| "email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@ni-ok-components-46c91ea3-1caa-4928-9d60-dca9c02b5797.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Upgrade to ESLint v9 and update the configuration to use the flat configuration format", | ||
| "packageName": "@ni/ok-components", | ||
| "email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@ni-ok-react-7a9c8a7b-7a2e-407f-ac4e-d1ef241f23fa.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Upgrade to ESLint v9 and update the configuration to use the flat configuration format", | ||
| "packageName": "@ni/ok-react", | ||
| "email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@ni-spright-angular-2c887b6f-ab13-4675-ab28-e2289e1d47b6.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Upgrade to ESLint v9 and update the configuration to use the flat configuration format", | ||
| "packageName": "@ni/spright-angular", | ||
| "email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@ni-spright-components-1c5f0ac7-e548-406d-bb8b-7b0273c385ab.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Upgrade to ESLint v9 and update the configuration to use the flat configuration format", | ||
| "packageName": "@ni/spright-components", | ||
| "email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@ni-spright-react-003b5663-da8a-4258-8d7b-b06dfbf0c21c.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Upgrade to ESLint v9 and update the configuration to use the flat configuration format", | ||
| "packageName": "@ni/spright-react", | ||
| "email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@ni-xliff-to-json-converter-dbea0b57-91b1-4a06-b7b9-07111d48a4b4.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Upgrade to ESLint v9 and update the configuration to use the flat configuration format", | ||
| "packageName": "@ni/xliff-to-json-converter", | ||
| "email": "131153319+gokulprasanth-ni@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi owners, I'm making some changes to the PR and will move it back out of draft when reviewed