Conversation
Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
…slint-to-flat-config Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
…vi/feat/update-nimble-eslint-to-flat-config
rajsite
commented
Dec 3, 2025
change/@ni-jasmine-parameterized-6c99369c-d30b-42ad-a468-fe1ff92ddb2c.json
Show resolved
Hide resolved
1 task
rajsite
commented
Dec 3, 2025
jattasNI
approved these changes
Dec 4, 2025
# Pull Request ## 🤨 Rationale This PR is the result of running format and cleaning up the result based on the changes in #2773 Note: This PR is intended to review the source changes that are made and will be merged into the `eslint-v9` branch, not `main`. ## 👩💻 Implementation Ran `npm run format` and tweaked the results a but to remove whitespace and address a couple rules that did not have automatic formatters. ## 🧪 Testing Rely on CI to report no visual diffs and pass. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: rajsite <1588923+rajsite@users.noreply.github.com>
Member
Author
|
Bypassing other owners for lint only changes |
rajsite
added a commit
that referenced
this pull request
Dec 6, 2025
# Pull Request ## 🤨 Rationale Removes inline pretter disable statements and updates docs to reference eslint Follow-up to #2773 ## 👩💻 Implementation See above ## 🧪 Testing Rely on CI ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: rajsite <1588923+rajsite@users.noreply.github.com>
rajsite
added a commit
that referenced
this pull request
Dec 8, 2025
# Pull Request ## 🤨 Rationale Enables markdown linting, pretty much the recommended ruleset of: - https://github.com/ota-meshi/eslint-plugin-markdown-preferences - https://github.com/ota-meshi/eslint-plugin-markdown-links Follow-up to #2773 ## 👩💻 Implementation Enabled the rules and fixed broken links (which are now checked internally between files, neat!) ## 🧪 Testing Rely on CI. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: rajsite <1588923+rajsite@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Adopts eslint v9 🎉
👩💻 Implementation
prettier-eslintwhich is in alpha builds for eslint v9 support, significantly hurt lint performance, and had major conflicts with eslint. Now that eslint libraries like stylistic are dedicated to style rules and eslint supports more formats such as markdown syntax and markdown style it's possible we don't need to rely on prettier long term. Either way we remove prettier for now to unblock eslint upgrades and can reconsider in the futurevalidateconcurrency scripts to run all lint sequentially in parallel to tests. Nowvalidatecompletes ~100s faster. It's also possible we will get another speed bump enabling multithreaded eslint but will save for a follow-up PR.eslint-config-nimblepackage:lintNimbleConfigconfiguration that is used in each eslint config to make sure the eslint config file itself is linted and to give a spot for very general shared config in follow-up PRs (like markdown or json linting)angularTypescriptNimbleConfigandangularTemplateNimbleConfig🧪 Testing
Note, see #2774 for CI results and source changes resulting from this config change.
✅ Checklist