This repository was archived by the owner on May 23, 2019. It is now read-only.
[WIP] Upgrade to prompt_toolkit 2.0#61
Open
jonathanslenders wants to merge 4 commits intonicolewhite:masterfrom
Open
[WIP] Upgrade to prompt_toolkit 2.0#61jonathanslenders wants to merge 4 commits intonicolewhite:masterfrom
jonathanslenders wants to merge 4 commits intonicolewhite:masterfrom
Conversation
jonathanslenders
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains the require changes for being compatible with the prompt_toolkit 2.0 release.
2.0 has not yet been released, but will be released soon.
Also see: prompt-toolkit/python-prompt-toolkit#568 and prompt-toolkit/python-prompt-toolkit#446
edit: By the way, I like how you did the completion for the different kind of braces. I wonder whether we need to provide something like that out of the box, or at least add something like that to the examples.