test: add implicit test for fs dispose handling with using #61140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61140 +/- ##
==========================================
- Coverage 88.53% 88.53% -0.01%
==========================================
Files 703 703
Lines 208546 208545 -1
Branches 40217 40225 +8
==========================================
- Hits 184634 184626 -8
+ Misses 15926 15917 -9
- Partials 7986 8002 +16 🚀 New features to boost your workflow:
|
Member
|
Should we be waiting until ERM is no longer flagged in V8 to start introducing these? |
LiviaMedeiros
added
dont-land-on-v20.x
Member
LiviaMedeiros
left a comment
LiviaMedeiros
left a comment
There was a problem hiding this comment.
It's unflagged on v24.x and beyond, so it should be fine to land with appropriate dont-land-on-*s.
| async function implicitCall() { | ||
| { | ||
| await using fh = await fs.open(__filename); | ||
| fh.on('close', common.mustCall()); |
Member
There was a problem hiding this comment.
This ensures only that fh is closed at some point, but we need to test that the filehandle is closed as soon as we exit the scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for implicit fs calls with
await usingsyntax