Skip to content

test: add implicit test for fs dispose handling with using #61140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IlyasShabi wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −1
Open

test: add implicit test for fs dispose handling with using #61140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion test/parallel/test-fs-promises-file-handle-dispose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,26 @@ async function explicitCall() {
assert.throws(() => dhSync.readSync(), { code: 'ERR_DIR_CLOSED' });
}

async function implicitCall() {
{
await using fh = await fs.open(__filename);
fh.on('close', common.mustCall());
Copy link
Member

@LiviaMedeiros LiviaMedeiros Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures only that fh is closed at some point, but we need to test that the filehandle is closed as soon as we exit the scope.

}

let dh;
{
await using dirHandle = await fs.opendir(__dirname);
dh = dirHandle;
}
await assert.rejects(dh.read(), { code: 'ERR_DIR_CLOSED' });

let dhSync;
{
using dirHandleSync = opendirSync(__dirname);
dhSync = dirHandleSync;
}
assert.throws(() => dhSync.readSync(), { code: 'ERR_DIR_CLOSED' });
}

explicitCall().then(common.mustCall());
// TODO(aduh95): add test for implicit calls, with `await using` syntax.
implicitCall().then(common.mustCall());
Loading