Skip to content

Use the automatic Make variable $@#17

Merged
nrnrnr merged 1 commit intonrnrnr:masterfrom
kwk:use-automatic-make-variable-at
Jan 31, 2022
Merged

Use the automatic Make variable $@#17
nrnrnr merged 1 commit intonrnrnr:masterfrom
kwk:use-automatic-make-variable-at

Conversation

@kwk
Copy link

@kwk kwk commented Jan 31, 2022

This was originally written by @turboencabulator and part of his PR #10.

We firgured it is easier to review when being available as an individual
commit/PR.

This was originally written by @turboencabulator and part of his PR nrnrnr#10.

We firgured it is easier to review when being available as an individual
commit/PR.
@kwk
Copy link
Author

kwk commented Jan 31, 2022

@nrnrnr this could be the smaller PR that you've been looking for in #10 (comment).

It

  1. uses $@ instead of repeating the target name
  2. replaces ; with && in situations where a directory i entered and then make is called
  3. replaces make with $(MAKE)

It think that this PR is easy to review in terms of complexity and I really hope it slims #10 a bit once this is merged and #10 is rebased.

@kwk kwk marked this pull request as ready for review January 31, 2022 09:47
Copy link
Owner

@nrnrnr nrnrnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely appreciate getting the && after all those cd commands.

@nrnrnr nrnrnr merged commit 50bbde0 into nrnrnr:master Jan 31, 2022
@kwk kwk deleted the use-automatic-make-variable-at branch February 4, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants