Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the nonce handling in UserOperation and PackedUserOperation to support uint256 values by converting them to strings internally. It also changes the @nucypher/nucypher-core dependency from an npm package version to a local linked directory for development purposes.
- Introduces
getUint256Stringhelper function to convert nonce values from bigint/number to string - Updates test assertions to compare nonce values as strings
- Refactors tests to use helper functions (
toCoreUserOperation,toCorePackedUserOperation) instead of direct constructors
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates dependency resolution to use local link for @nucypher/nucypher-core |
| packages/test-utils/package.json | Changes dependency to local path ../../../nucypher-core/nucypher-core-wasm-bundler |
| packages/taco/package.json | Changes dependency to local path ../../../nucypher-core/nucypher-core-wasm-bundler |
| packages/shared/package.json | Changes dependency to local path ../../../nucypher-core/nucypher-core-wasm-bundler |
| packages/pre/package.json | Changes dependency to local path ../../../nucypher-core/nucypher-core-wasm-bundler |
| package.json | Changes dependency to link:../nucypher-core/nucypher-core-wasm-bundler |
| packages/shared/src/types.ts | Adds getUint256String function and updates nonce handling to use string representation |
| packages/shared/test/porter.test.ts | Removes unused imports and refactors to use helper functions for creating UserOperation objects |
| packages/taco/test/taco-sign.test.ts | Updates nonce comparison logic to compare string representations |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vzotova
approved these changes
Nov 20, 2025
theref
approved these changes
Nov 20, 2025
cygnusv
reviewed
Nov 20, 2025
cygnusv
approved these changes
Nov 20, 2025
… regarding nonce value being provided as uint256 string.
…ide nonce as a string. Update tests to account for nonce being returned as a string.
8947e9d to
108eebb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## signing-epic #739 +/- ##
===============================================
Coverage ? 90.13%
===============================================
Files ? 97
Lines ? 8453
Branches ? 296
===============================================
Hits ? 7619
Misses ? 831
Partials ? 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Before merging: update version of
nucypher-coreused - a new dev release will be neededType of PR:
Required reviews:
What this does:
Depends on nucypher/nucypher-core#126
Issues fixed/closed:
Why it's needed:
Notes for reviewers: