Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #92 +/- ##
==========================================
- Coverage 43.66% 43.63% -0.04%
==========================================
Files 283 283
Lines 8093 8099 +6
Branches 1562 1564 +2
==========================================
Hits 3534 3534
- Misses 4464 4470 +6
Partials 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eantones
force-pushed
the
16.0-fix-lighting_export_xlsx-concurrent_write
branch
8 times, most recently
from
4328024 to
c708d6d
Compare
… loop The ORM write for setting attachments as public during export created dirty records that conflicted with concurrent workers during flush_all/invalidate_all at batch boundaries (SerializationFailure). Move the public write out of the per-product loop entirely. Instead, do a single search + write after all product data is generated. This keeps the batch loop read-only and avoids concurrent access issues.
eantones
force-pushed
the
16.0-fix-lighting_export_xlsx-concurrent_write
branch
from
c708d6d to
7a0be38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SerializationFailurewhen another worker modifies the same attachments during the long export transactionwrite({"public": True})creates dirty records that conflict duringflush_all()at batch boundariesTest plan