Conversation
The public=True write inside export_xlsx causes concurrent access issues in any caller that processes many products, not just the XLSX export. Remove the fallback write entirely — export_xlsx is now purely read-only. The caller is responsible for setting the non_public_attachment_ids context key and doing the write at the end.
eantones
force-pushed
the
16.0-fix-lighting_export_xlsx-remove_write_from_export
branch
from
f3f8b22 to
ee9d583
Compare
eantones
deleted the
16.0-fix-lighting_export_xlsx-remove_write_from_export
branch
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #93 +/- ##
==========================================
+ Coverage 43.63% 43.65% +0.01%
==========================================
Files 283 283
Lines 8099 8096 -3
Branches 1564 1563 -1
==========================================
Hits 3534 3534
+ Misses 4470 4467 -3
Partials 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write({"public": True})fromexport_xlsxon attachments