Skip to content

[16.0][FIX] lighting_export_xlsx: remove write from export_xlsx on attachments #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eantones merged 1 commit into from
Mar 25, 2026
Merged

[16.0][FIX] lighting_export_xlsx: remove write from export_xlsx on attachments #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lighting_export_xlsx/models/product_attachment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,7 @@ def export_xlsx(self, template_id=None):
if prod_attachment_ids.mapped("attachment_id"):
non_public = prod_attachment_ids.filtered(lambda x: not x.public)
if non_public:
ids_list = self.env.context.get("non_public_attachment_ids")
if ids_list is not None:
ids_list.extend(non_public.ids)
else:
non_public.sudo().write({"public": True})
self.env.context["non_public_attachment_ids"].extend(non_public.ids)
for pa in prod_attachment_ids:
res.append(
OrderedDict(
Expand Down
Loading