Skip to content

Add database.sm.tolerations template to HotCopy SM #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

Add database.sm.tolerations template to HotCopy SM #406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4368f8
Fix a missed toleration template
kontaras Oct 6, 2025
b906f6d
Merge branch 'master' into kontaras/missed-toleration
kontaras Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/database/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ spec:
{{- end }}
{{- if .Values.database.sm.tolerations }}
tolerations:
{{ toYaml .Values.database.sm.tolerations | trim | indent 8 }}
{{ include "database.sm.tolerations" . | trim | indent 8 }}
Copy link
Collaborator

@sivanov-nuodb sivanov-nuodb Oct 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Are you going to update the test as well?

Copy link
Contributor Author

@kontaras kontaras Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What test needs updating? The TestDatabaseTolerations tests HotCopy SMs but did not catch this because it is a regression test and the charts in this repo continued to behave correctly. This issue will only come up if we want to add HotCopy SMs to the 3DS helm charts.

Copy link
Collaborator

@sivanov-nuodb sivanov-nuodb Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Thanks for the explanation!

{{- end }}
{{- include "database.sm.shareProcessNamespace" . | indent 6 -}}
{{- if eq (include "defaulttrue" .Values.database.initContainers.runInitDisk) "true" }}
Expand Down