Set min setuptools version#13
Merged
bryevdv merged 1 commit intonv-legate:mainfrom May 22, 2025
bryevdv:bv/setuptools-version
Merged
Set min setuptools version#13bryevdv merged 1 commit intonv-legate:mainfrom bryevdv:bv/setuptools-version
bryevdv merged 1 commit intonv-legate:mainfrom
bryevdv:bv/setuptools-version
Conversation
Jacobfaib
reviewed
May 22, 2025
|
|
||
| [build-system] | ||
| requires = ["rich", "setuptools", "setuptools-scm"] | ||
| requires = ["rich", "setuptools>80", "setuptools-scm"] |
Contributor
Author
There was a problem hiding this comment.
There are several "80" versions, so I didn't think it mattered at this point, really.
Contributor
There was a problem hiding this comment.
I think it's instructive for a future reader to know exactly what version introduced what we need. >80 could mean 81, or 80.0.1
Contributor
There was a problem hiding this comment.
In any case, not a huge deal, I won't hold up the PR over this
Jacobfaib
approved these changes
May 22, 2025
|
|
||
| [build-system] | ||
| requires = ["rich", "setuptools", "setuptools-scm"] | ||
| requires = ["rich", "setuptools>80", "setuptools-scm"] |
Contributor
There was a problem hiding this comment.
In any case, not a huge deal, I won't hold up the PR over this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.