Skip to content

Set min setuptools version #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryevdv merged 1 commit into from
May 22, 2025
Merged

Set min setuptools version #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# SPDX-License-Identifier: Apache-2.0

[build-system]
requires = ["rich", "setuptools", "setuptools-scm"]
requires = ["rich", "setuptools>80", "setuptools-scm"]
Copy link
Copy Markdown
Contributor

@Jacobfaib Jacobfaib May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>80 or >=80?

Copy link
Copy Markdown
Contributor Author

@bryevdv bryevdv May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several "80" versions, so I didn't think it mattered at this point, really.

Copy link
Copy Markdown
Contributor

@Jacobfaib Jacobfaib May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's instructive for a future reader to know exactly what version introduced what we need. >80 could mean 81, or 80.0.1

Copy link
Copy Markdown
Contributor

@Jacobfaib Jacobfaib May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, not a huge deal, I won't hold up the PR over this

build-backend = "setuptools.build_meta"

[project]
Expand Down
Loading