Update code to use the default definition of out_width on OCaml 5.4+#10
Merged
Leonidas-from-XIV merged 1 commit intomasterfrom Feb 14, 2025
Merged
Update code to use the default definition of out_width on OCaml 5.4+#10Leonidas-from-XIV merged 1 commit intomasterfrom
out_width on OCaml 5.4+#10Leonidas-from-XIV merged 1 commit intomasterfrom
Conversation
Introduced in ocaml/ocaml#13570 Signed-off-by: Marek Kubica <marek@tarides.com>
Alizter
approved these changes
Feb 14, 2025
Collaborator
Alizter
left a comment
Alizter
left a comment
There was a problem hiding this comment.
Seems reasonable to me.
Collaborator
|
Did you check the build with many OCaml versions upstream (in Dune)? |
Author
|
I haven't yet, since I can't build notty locally on 5.4 with current dune because I can't build Dune on 5.4. But I'll create a PR updating the vendored copy to the code in this PR, that should show that it works on 5.4 in CI, give me a moment... |
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/dune
that referenced
this pull request
Feb 14, 2025
PR in question is ocaml-dune/notty#10 Signed-off-by: Marek Kubica <marek@tarides.com>
Author
|
@Alizter Looks like that this workaround builds fine on 5.4: https://github.com/ocaml/dune/actions/runs/13329716284/job/37230745602?pr=11482 Let's see if tests also succeed. |
Author
|
Ok, tests are succeeding (or, well, failing for unrelated issues); merging. |
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/dune
that referenced
this pull request
Feb 14, 2025
PR in question is ocaml-dune/notty#10 Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
added a commit
to ocaml/dune
that referenced
this pull request
Feb 14, 2025
PR in question is ocaml-dune/notty#10 Signed-off-by: Marek Kubica <marek@tarides.com>
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Apr 22, 2025
PR in question is ocaml-dune/notty#10 Signed-off-by: Marek Kubica <marek@tarides.com>
Sudha247
pushed a commit
to Sudha247/dune
that referenced
this pull request
Jul 23, 2025
PR in question is ocaml-dune/notty#10 Signed-off-by: Marek Kubica <marek@tarides.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in ocaml/ocaml#13570 this change reads the defaults and updates them instead of constructing the record from scratch. This way it should be compatible with older versions (
Format.get_formatter_out_functionsis from 4.01, so safe to use).