Update vendored notty to include OCaml 5.4 support#11482
Merged
Leonidas-from-XIV merged 1 commit intoocaml:mainfrom Feb 14, 2025
Merged
Update vendored notty to include OCaml 5.4 support#11482Leonidas-from-XIV merged 1 commit intoocaml:mainfrom
Leonidas-from-XIV merged 1 commit intoocaml:mainfrom
Conversation
Collaborator
Author
|
Converting to draft as the commit that should be included should be the one that ends up getting merged, not from my PR but this PR should be able to show that the vendored notty builds on 5.4 thus making Dune compatible again. |
PR in question is ocaml-dune/notty#10 Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
notty-5.4-support
branch
from
ae48b66 to
25e607e
Compare
Collaborator
Author
|
Changed the commit hash to the one of the merge commit; with that I think this PR is ready to be reviewed. |
emillon
approved these changes
Feb 14, 2025
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Apr 22, 2025
PR in question is ocaml-dune/notty#10 Signed-off-by: Marek Kubica <marek@tarides.com>
Sudha247
pushed a commit
to Sudha247/dune
that referenced
this pull request
Jul 23, 2025
PR in question is ocaml-dune/notty#10 Signed-off-by: Marek Kubica <marek@tarides.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR in question is ocaml-dune/notty#10