Clarify GetAssignedMediaSigningCertificates response behavior#739
Open
bsriramprasad wants to merge 5 commits intodevelopmentfrom
Open
Clarify GetAssignedMediaSigningCertificates response behavior#739bsriramprasad wants to merge 5 commits intodevelopmentfrom
bsriramprasad wants to merge 5 commits intodevelopmentfrom
Conversation
HansBusch
requested changes
Mar 13, 2026
Member
HansBusch
left a comment
HansBusch
left a comment
There was a problem hiding this comment.
Generally prefer previous overview.
Suggest to not put details regarding hardware in this section of the security spec. Either discuss it generally or leave out.
Please replace misleading by content.
| MEMBERS OR THEIR AFFILIATES HAVE BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES, OR (2) | ||
| SUCH DAMAGES WERE REASONABLY FORESEEABLE, AND ARISING OUT OF OR RELATING TO ANY USE OR | ||
| DISTRIBUTION OF THIS DOCUMENT. THE FOREGOING DISCLAIMER AND LIMITATION ON LIABILITY DO NOT | ||
| DISTRIBUTION OF THIS DOCUMENT. THE FOREGOING DISCLAIMER AND LIMITATION ON LIABILITY DO NOT |
Contributor
There was a problem hiding this comment.
nit: Is this extra white space added deliberately?
Contributor
Author
There was a problem hiding this comment.
I guess I saw this after rebase to main, not sure if I added it.
kieran242
reviewed
Mar 30, 2026
Contributor
kieran242
left a comment
kieran242
left a comment
There was a problem hiding this comment.
@bsriramprasad I am happy enough with this content. Have you updated the changes blocked by @HansBusch or did I miss the content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://www.onvif.org/specs/srv/security/ONVIF-Security-Service-Spec.pdf
Section 5.5.4 GetAssignedMediaSigningCertificates
CertificationPathID - optional, max 2 [tas:CertificationPathID]
This interface is actually returning a LIST of 'CertificationPathIDs', with a minimum of 1 and maximum of 2 in the list, but the interface name looks like its returning list of CertificateIDs, which led to query from the DTT vendor.
Hence this PR clarifies that client need to make an extra call to GetCertificationPath to actually retrieve certificates.
In addition did few edits to improve the section readability.