Skip to content

Conversation

@keelerm84
Copy link
Contributor

No description provided.

@keelerm84 keelerm84 requested a review from a team as a code owner January 15, 2026 15:05
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @keelerm84, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a numbering inconsistency within the OpenFeature specification. It specifically renumbers the conditional requirement concerning the immutability of flag metadata from 1.4.14.1 to 1.4.15.1. This change ensures that all references to this requirement are consistent and correctly aligned throughout the specification's various formats, including its machine-readable JSON, Gherkin feature tests, and Markdown documentation.

Highlights

  • Specification Renumbering: The conditional requirement for immutable flag metadata has been renumbered from 1.4.14.1 to 1.4.15.1.
  • Documentation Updates: References to the renumbered requirement have been updated across the specification.json, evaluation_v2.feature Gherkin file, and 01-flag-evaluation.md documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Signed-off-by: Matthew Keeler <mkeeler@launchdarkly.com>
@keelerm84 keelerm84 force-pushed the feat/fix-requirement-numbering branch from fcaa56c to 39d1bdf Compare January 15, 2026 15:05
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes the numbering for the immutable flag metadata requirement from 1.4.14.1 to 1.4.15.1 across the specification files. The changes are consistent and accurate. I've added one comment in the Gherkin feature file to point out a pre-existing lack of clarity in a test scenario that could be improved.

# Testing immutability requirements (Spec 1.4.15/1.4.15.1)
# Testing: flag metadata must be immutable
@immutability @spec-1.4.14.1
@immutability @spec-1.4.15.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the renumbering to 1.4.15.1 is correct, there's some confusion in this scenario. The spec requirement 1.4.15.1 is about Flag metadata immutability, but the scenario is named Evaluation context immutability (line 494) and also seems to test evaluation context immutability (which is covered by spec 4.1.4.1).

To improve clarity, you could consider renaming the scenario to better reflect that it tests both context and details immutability, and adding the @spec-4.1.4.1 tag.

@beeme1mr
Copy link
Member

Thanks @keelerm84! I'm going to merge this because it's a clear typo and doesn't change the intent defined by the spec.

@beeme1mr beeme1mr merged commit 5c38868 into open-feature:main Jan 23, 2026
6 checks passed
@keelerm84 keelerm84 deleted the feat/fix-requirement-numbering branch January 23, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants