Skip to content

fix!: Fix numbering for immutable flag metadata requirement #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beeme1mr merged 1 commit into from
Jan 23, 2026
Merged

fix!: Fix numbering for immutable flag metadata requirement #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@
"RFC 2119 keyword": null,
"children": [
{
"id": "Conditional Requirement 1.4.14.1",
"machine_id": "conditional_requirement_1_4_14_1",
"id": "Conditional Requirement 1.4.15.1",
"machine_id": "conditional_requirement_1_4_15_1",
"content": "Condition: `Flag metadata` MUST be immutable.",
"RFC 2119 keyword": "MUST",
"children": []
Expand Down
4 changes: 2 additions & 2 deletions specification/assets/gherkin/evaluation_v2.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,9 +488,9 @@ Feature: Flag Evaluations - Complete OpenFeature Specification Coverage
And the hook order should be maintained


# Testing immutability requirements (Spec 1.4.15/1.4.14.1)
# Testing immutability requirements (Spec 1.4.15/1.4.15.1)
# Testing: flag metadata must be immutable
@immutability @spec-1.4.14.1
@immutability @spec-1.4.15.1
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the renumbering to 1.4.15.1 is correct, there's some confusion in this scenario. The spec requirement 1.4.15.1 is about Flag metadata immutability, but the scenario is named Evaluation context immutability (line 494) and also seems to test evaluation context immutability (which is covered by spec 4.1.4.1).

To improve clarity, you could consider renaming the scenario to better reflect that it tests both context and details immutability, and adding the @spec-4.1.4.1 tag.

Scenario: Evaluation context immutability
Given a Boolean-flag with key "boolean-flag" and a fallback value "false"
And an evaluation context with modifiable data
Expand Down
2 changes: 1 addition & 1 deletion specification/sections/01-flag-evaluation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ This `flag metadata` field is intended as a mechanism for providers to surface a

> The implementation language supports a mechanism for marking data as immutable.

##### Conditional Requirement 1.4.14.1
##### Conditional Requirement 1.4.15.1

> Condition: `Flag metadata` **MUST** be immutable.

Expand Down
Loading